Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use float histogram for otel metrics #1303

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: use float histogram for otel metrics #1303

merged 1 commit into from
Aug 30, 2024

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • When we first introduced OTel metrics to Refinery, we only had int histograms to work with. But now float ones are available and the int one can yield very surprising results when your values are close to 0.

Short description of the changes

  • Replace Int64Histogram with Float64Histogram
  • That's it.

We think that since we've never heard about this one before, it's probably the case that most people using histograms are using them for larger values, and so there won't be any real-life impact from this change.

@kentquirk kentquirk self-assigned this Aug 30, 2024
@kentquirk kentquirk requested a review from a team as a code owner August 30, 2024 19:14
@kentquirk kentquirk added this to the v2.8 milestone Aug 30, 2024
@kentquirk kentquirk merged commit 51d9c7d into main Aug 30, 2024
6 checks passed
@kentquirk kentquirk deleted the kent.float_histo branch August 30, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants