Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve log messages to be more informative #1322

Merged
merged 4 commits into from
Sep 16, 2024
Merged

feat: Improve log messages to be more informative #1322

merged 4 commits into from
Sep 16, 2024

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Sep 12, 2024 •
edited
Loading

Which problem is this PR solving?

Improve some log messages to be more accurate about what's actually happening.

Short description of the changes

  • Improve log messages
  • Prefer using WithField / WithString to include parameters instead of inline formatting
  • Update memory overrun messages from error -> warn - they do not constitute data lost so error feels heavy handed

@MikeGoldsmith MikeGoldsmith self-assigned this Sep 12, 2024
@MikeGoldsmith MikeGoldsmith requested a review from a team as a code owner September 12, 2024 12:08
@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Sep 12, 2024
@MikeGoldsmith MikeGoldsmith added this to the v2.9 milestone Sep 12, 2024
VinozzZ
VinozzZ approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just have two suggestions

collect/collect.go Outdated Show resolved Hide resolved
collect/collect.go Outdated Show resolved Hide resolved
@MikeGoldsmith @kentquirk
Apply suggestions from code review
23f42b8 
Co-authored-by: Kent Quirk <kentquirk@honeycomb.io>
mterhar
mterhar reviewed Sep 13, 2024
View reviewed changes
Copy link

@mterhar mterhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we mostly consistent about error logs come out every time data is dropped? And then a retry or early decision with some delivery time or sampling impact is a warning?

collect/collect.go Show resolved Hide resolved
@MikeGoldsmith MikeGoldsmith merged commit ef1cd35 into main Sep 16, 2024
6 checks passed
@MikeGoldsmith MikeGoldsmith deleted the mike/log-messages branch September 16, 2024 16:15
TylerHelmuth pushed a commit that referenced this pull request Oct 16, 2024
@MikeGoldsmith @kentquirk @TylerHelmuth
feat: Improve log messages to be more informative (#1322)
f6589e1 
## Which problem is this PR solving?

Improve some log messages to be more accurate about what's actually
happening.

- closes #1321

## Short description of the changes
- Improve log messages
- Prefer using WithField / WithString to include parameters instead of
inline formatting
- Update memory overrun messages from error -> warn - they do not
constitute data lost so error feels heavy handed

---------

Co-authored-by: Kent Quirk <kentquirk@honeycomb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mterhar mterhar mterhar left review comments

@kentquirk kentquirk kentquirk left review comments

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.

Make log messages more self-explanatory
4 participants
@MikeGoldsmith @kentquirk @mterhar @VinozzZ