Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ConvertNumeric now handles bools #1336

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: ConvertNumeric now handles bools #1336

merged 2 commits into from
Sep 17, 2024

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented Sep 17, 2024 •
edited by MikeGoldsmith
Loading

Which problem is this PR solving?

Short description of the changes

  • Add bool case to ConvertNumeric
  • Add test for ConvertNumeric function

@kentquirk kentquirk requested a review from a team as a code owner September 17, 2024 16:07
@kentquirk kentquirk self-assigned this Sep 17, 2024
@kentquirk kentquirk added this to the v2.9 milestone Sep 17, 2024
MikeGoldsmith
MikeGoldsmith approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one minor suggestion for the switch statement.

metrics/metrics.go Outdated Show resolved Hide resolved
@kentquirk kentquirk merged commit 6afebb7 into main Sep 17, 2024
5 checks passed
@kentquirk kentquirk deleted the kent.metric_bools branch September 17, 2024 16:26
MikeGoldsmith pushed a commit that referenced this pull request Oct 10, 2024
@kentquirk @MikeGoldsmith
fix: ConvertNumeric now handles bools (#1336)
e09d23b 
## Which problem is this PR solving?

- Closes #1335 

## Short description of the changes

- Add bool case to ConvertNumeric
- Add test for ConvertNumeric function
@TylerHelmuth TylerHelmuth removed this from the v2.9 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@kentquirk kentquirk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_alive and is_ready metrics are always zero
3 participants
@kentquirk @MikeGoldsmith @TylerHelmuth