maint: rename sent_reason_cache to kept_reason_cache #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
approved these changes
Sep 20, 2024
| @@ -480,12 +480,12 @@ func (i *InMemCollector) processSpan(sp *types.Span) { | |||
| trace := i.cache.Get(sp.TraceID) | |||
| if trace == nil { | |||
| // if the trace has already been sent, just pass along the span | |||
| if sr, sentReason, found := i.sampleTraceCache.CheckSpan(sp); found { | |||
| if sr, keptReason, found := i.sampleTraceCache.CheckSpan(sp); found { | |||
| i.Metrics.Increment("trace_sent_cache_hit") | |||
There was a problem hiding this comment.
maybe change the name of this metric? And are there other ones?
There was a problem hiding this comment.
I think this one is ok. This metric is for the TraceSentCache, not the keptReasonCache. Hopefully with this rename, things will be a bit more clear
My apology that the PR description wasn't specific enough. I just updated it. This PR is only renaming things that are related to the |
TylerHelmuth
pushed a commit
that referenced
this pull request
Oct 16, 2024
## Which problem is this PR solving? In the `collector`, we use `sendReason` to describe why a trace is moved into the decision-making process. Additionally, we have `sentReason`, which indicates the reason behind a trace receiving a “kept” decision. To avoid confusion between these terms when sharing this information from the decider node to the rest of the cluster, I propose renaming `sentReasonCache` to `keptReasonCache` to better reflect its purpose. ## Short description of the changes - rename all `sentReasonCache` to `keptReasonCache`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In the
collector, we usesendReasonto describe why a trace is moved into the decision-making process. Additionally, we havesentReason, which indicates the reason behind a trace receiving a “kept” decision.To avoid confusion between these terms when sharing this information from the decider node to the rest of the cluster, I propose renaming
sentReasonCachetokeptReasonCacheto better reflect its purpose.Short description of the changes
sentReasonCachetokeptReasonCache