feat: Improve shutdown logic #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
force-pushed
the
kent.safer_shutdown
branch
from
4976146 to
59ffaee
Compare
MikeGoldsmith
approved these changes
Sep 23, 2024
TylerHelmuth
pushed a commit
that referenced
this pull request
Oct 16, 2024
## Which problem is this PR solving? - If part of Refinery has a problem shutting down, there's no way to force it other than to do a `kill -9`, which is a pain. ## Short description of the changes - Call the Stop() routines in the shutdown rather than in a defer() - Instead of simply blocking on the signal channel, monitor that channel in a goroutine. If more than one shutdown signal is received, exit immediately without trying to be clean about it. - Also, if a shutdown signal is received and the health system is already "not alive", just die immediately; there's a good chance the system won't be able to do an orderly shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
kill -9, which is a pain.Short description of the changes