fix: set 0 for otel metrics during registration #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinozzZ
force-pushed
the
yingrong.otel_metrics_initialization
branch
from
f53f8c5 to
dd8efd7
Compare
MikeGoldsmith
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Honeycomb’s board template requires that columns be created before any queries can be added. However, in OpenTelemetry (OTel), metrics are not sent until they have a value, which caused an issue where customers missed queries on their Refinery boards during the initial setup of their instances.
This PR addresses the issue by setting a default value of 0 for all OTel metrics during the Register call. This ensures that OTel sends these metrics to Honeycomb immediately upon Refinery startup, preventing gaps in the board’s initial queries.
Short description of the changes