feat: Record original user agent for spans and logs #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
changed the title
|
We'll also want to make an update in shepherd telemetry to capture this like we do the user_agents strings today. |
|
Looks like this has broken with the new trace locality feature. I'll work on fixing tests. |
MikeGoldsmith
added a commit
that referenced
this pull request
Oct 4, 2024
## Which problem is this PR solving? Refinery loses the original user agent of the sending application because it aggregates spans until a trace decision is made. This PR records the original user agent for both HTTP and gRPC requests to the event, batch and OTLP trace/log endpoints in a new metadata field `meta.refinery.incoming_user_agent`. - Closes #1356 ## Short description of the changes - Update event, batch, OTLP trace/logs endpoints to record original user agent in new field - Update tests to verify events have the new field set - Add defer for bad API key test to restore allowed keys so subsequent tests can pass # Conflicts: # app/app_test.go # route/route.go
MikeGoldsmith
added a commit
that referenced
this pull request
Oct 7, 2024
## Which problem is this PR solving? Following up to the following PR, we should only set the incoming user agent if the key does not already exist. This is useful in certain scenarios when two Refinery's are connected together. - #1358 ## Short description of the changes - Only set incoming user agent meta field if the event doesn't already have a value for it - Add unit test to verify behaviour - Update existing tests to set custom user-agent and verify it's set correctly
MikeGoldsmith
added a commit
that referenced
this pull request
Oct 7, 2024
## Which problem is this PR solving? Following up to the following PR, we should only set the incoming user agent if the key does not already exist. This is useful in certain scenarios when two Refinery's are connected together. - #1358 ## Short description of the changes - Only set incoming user agent meta field if the event doesn't already have a value for it - Add unit test to verify behaviour - Update existing tests to set custom user-agent and verify it's set correctly # Conflicts: # app/app_test.go # route/route_test.go
TylerHelmuth
pushed a commit
that referenced
this pull request
Oct 16, 2024
Refinery loses the original user agent of the sending application because it aggregates spans until a trace decision is made. This PR records the original user agent for both HTTP and gRPC requests to the event, batch and OTLP trace/log endpoints in a new metadata field `meta.refinery.incoming_user_agent`. - Closes #1356 - Update event, batch, OTLP trace/logs endpoints to record original user agent in new field - Update tests to verify events have the new field set - Add defer for bad API key test to restore allowed keys so subsequent tests can pass
TylerHelmuth
pushed a commit
that referenced
this pull request
Oct 16, 2024
Following up to the following PR, we should only set the incoming user agent if the key does not already exist. This is useful in certain scenarios when two Refinery's are connected together. - #1358 - Only set incoming user agent meta field if the event doesn't already have a value for it - Add unit test to verify behaviour - Update existing tests to set custom user-agent and verify it's set correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Refinery loses the original user agent of the sending application because it aggregates spans until a trace decision is made. This PR records the original user agent for both HTTP and gRPC requests to the event, batch and OTLP trace/log endpoints in a new metadata field
meta.refinery.incoming_user_agent.Short description of the changes