implement optional soft allocation ceiling #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdvalenzuela
approved these changes
Sep 17, 2020
Co-authored-by: asdvalenzuela <asdvalenzuela@honeycomb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new MaxAlloc config value. If > 0, InMemCollector will periodically check to see if the process's total allocation is above the limit. If it is, it will send and discard 10% of traces, and reduce the cache capacity to the new size. For this to work well, it should be set to about 75%-90% of available RAM, to leave room for scratch space and various fluctuations.
The intention is that this is a failsafe for if the cache capacity has been set too high; if it triggers regularly, users should lower their starting cache capacity and/or add machines to their samproxy cluster.
Depends on #138