Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document the ability to use prefix in dynamic sampler FieldList #1396

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

irvingpop
Copy link
Contributor

Short description of the changes

Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
@irvingpop irvingpop requested a review from a team as a code owner October 22, 2024 23:06
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

For future reference, we generally don't check in the autogenerated files for intermediate PRs; they get built as one of the steps in our release protocol. No harm done, but it minimizes the number of things to review.

@MikeGoldsmith MikeGoldsmith merged commit ce34790 into main Oct 23, 2024
6 checks passed
@MikeGoldsmith MikeGoldsmith deleted the irving/pr1275_docs_update branch October 23, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants