Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explictly assign float64 type for trace cache metrics #1406

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: explictly assign float64 type for trace cache metrics #1406

merged 1 commit into from
Oct 31, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Oct 31, 2024

Which problem is this PR solving?

in Go, numeric constants are untyped. We need to explicitly assign float64 to the result in order to get floating-point result

Short description of the changes

  • assign the duration metrics to float64

@VinozzZ VinozzZ requested a review from a team as a code owner October 31, 2024 22:17
@VinozzZ VinozzZ self-assigned this Oct 31, 2024
@VinozzZ VinozzZ added the type: bug Something isn't working label Oct 31, 2024
@VinozzZ VinozzZ added this to the v2.9 milestone Oct 31, 2024
@VinozzZ VinozzZ merged commit de471da into main Oct 31, 2024
6 checks passed
@VinozzZ VinozzZ deleted the yingrong/deal_with_orphan_traces branch October 31, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees

@VinozzZ VinozzZ

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@VinozzZ @kentquirk