fix: deal with orphan traces and expired traces #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinozzZ
force-pushed
the
yingrong/debug_collect_loop
branch
from
13a4a9e to
cdb839f
Compare
MikeGoldsmith
pushed a commit
that referenced
this pull request
Nov 7, 2024
## Which problem is this PR solving? To reduce ingest latency, moving the work for publishing kept trace decisions into a separate goroutine so it doesn't block ingest incoming data. This code has been running in kibble for a few days and it's copied from the debug branch #1408 ## Short description of the changes - create a buffer for kept trace decision - make publishing kept trace decision non-blocking in the `collect` loop
VinozzZ
changed the title
MikeGoldsmith
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
There are two special types of traces based on trace's SendBy value, orphan traces and expired traces.
Orphan trace is a trace's SendBy has passed for more than 4 times of configured trace timeout.
Expired trace is a trace's SendBy has passed for more than 2 times of configured trace timeout.
For an orphan trace, we should just go ahead with decision making since the decider has no knowledge about it. Therefore, under memory pressure, we should get rid of orphan traces as well.
This PR also makes sure decision spans sent for expired traces are not being added into trace cache in the peers and the signal is only sent once per expired trace.
Short description of the changes
checkAllocmeta.refinery.expired_traceflag in the decision span sent for expired tracesRetriedflag on the trace objectcollectloop