Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only enalbe stress relief for the entire cluster together #1413

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Nov 6, 2024

Which problem is this PR solving?

When making distributed trace decisions, load is more evenly balanced across nodes in the cluster. This balanced load means that, ideally, each node should experience a similar level of stress.

Because of this, the entire cluster should activate stress relief mode collectively, rather than allowing individual nodes to enter stress relief independently. If a single node goes into stress relief on its own, it will lead to missing span information across the cluster. This discrepancy would result in inconsistent trace decisions between the stressed node and the rest of the cluster, potentially impacting the reliability of trace sampling decisions.

Short description of the changes

  • calculate stress relief activation based on only cluster_stress_level
  • modify stress reasons to match with the configuration options
  • add test for the new stress relief activation calculation

@VinozzZ VinozzZ added the type: enhancement New feature or request label Nov 6, 2024
@VinozzZ VinozzZ added this to the v2.9 milestone Nov 6, 2024
@VinozzZ VinozzZ self-assigned this Nov 6, 2024
@VinozzZ VinozzZ requested a review from a team as a code owner November 6, 2024 22:58
@VinozzZ VinozzZ merged commit 0a6b8ad into main Nov 7, 2024
5 checks passed
@VinozzZ VinozzZ deleted the yingrong/cluster_stress_relief branch November 7, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants