feat: batch kept decisions #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
approved these changes
Nov 8, 2024
collect/collect.go
Outdated
| if trace == nil { | ||
| i.Logger.Debug().Logf("trace not found in cache for trace decision") | ||
| return | ||
| // Send the processed trace (only in Kept case) |
There was a problem hiding this comment.
I think we can consolidate these two if blocks together.
There was a problem hiding this comment.
I realized that we should still call send for dropped traces since the trace_send_dropped metric is in there and it does check against trace.Kept inside send anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The throughput of Redis pub/sub is impacted by the number of messages sent per time unit. To improve performance and ensure a higher throughput of kept messages, we need to reduce the number of kept messages sent.
This PR implements a batching strategy similar to the one used for dropped messages, reducing the frequency of sending individual kept messages.
Short description of the changes