send excess traces when reducing cache size #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin308
approved these changes
Sep 17, 2020
collect/collect.go
Outdated
| Metrics: i.Metrics, | ||
| Logger: i.Logger, | ||
| } | ||
| c.Start() |
There was a problem hiding this comment.
maybe we could just get rid of the start function? We don't have a matching stop function and it seems to just create some data structures that could be created upfront when we make the initial struct?
asdvalenzuela
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes an off-by-one error in the cache building loop, and adds a mutex to mock config to avoid test races.