feat(experiment): make drop decision queue size configurable #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinozzZ
changed the title
VinozzZ
force-pushed
the
yingrong/make_drop_decision_queue_configurable
branch
from
f08fdf0 to
7bd123b
Compare
| @@ -50,13 +50,16 @@ var cuckooTraceCheckerMetrics = []metrics.Metadata{ | |||
| {Name: CurrentLoadFactor, Type: metrics.Gauge, Unit: metrics.Percent, Description: "the fraction of slots occupied in the current cuckoo filter"}, | |||
| } | |||
|
|
|||
| func NewCuckooTraceChecker(capacity uint, m metrics.Metrics) *CuckooTraceChecker { | |||
| func NewCuckooTraceChecker(capacity uint, addQueueDepth uint, m metrics.Metrics) *CuckooTraceChecker { | |||
There was a problem hiding this comment.
addQueueDepth param isn't used, should it be used on line 62?
route/route.go
Outdated
There was a problem hiding this comment.
Are these changes related to drop queue size or fixing that bug where we don't increment the right metrics for OTLP ingest during stress relief?
There was a problem hiding this comment.
Sorry, this PR is my experimental PR. I'm not planning to merge it. I shouldn't have marked it for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
cuckoo_addqueue_fullshows full when experimenting HPA. I would like to increase the queue size since now each refinery will hold all trace decisions in the cluster instead of just 1/Nthbenchmark with the queue size increased from 1000 to 10000
Short description of the changes
DroppedQueueSizeconfig optionincoming/peer_router_otlpmetric to track otlp traffic