Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add incoming/peer_router_otlp metrics for otlp traffic #1474

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Jan 22, 2025

Which problem is this PR solving?

We have don't have metrics for otlp traffic in Refinery. It's hard to see traffic load from otlp requests

Short description of the changes

  • add incoming/peer_router_otlp metrics
  • also fixes missing registration for some existing metrics

@VinozzZ VinozzZ self-assigned this Jan 22, 2025
@VinozzZ VinozzZ requested a review from a team as a code owner January 22, 2025 19:59
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm glad you caught the missing metrics.

@VinozzZ VinozzZ merged commit 70ca257 into main Jan 23, 2025
5 checks passed
@VinozzZ VinozzZ deleted the yingrong/otel_metrics branch January 23, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants