Rules Base Sampler #151
Merged
Rules Base Sampler #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdvalenzuela
approved these changes
Sep 23, 2020
sample/rules_test.go
Outdated
| Rule: []*config.RulesBasedSamplerRule{ | ||
| { | ||
| Name: "drop", | ||
| SampleRate: 0, |
There was a problem hiding this comment.
In our other sampler configs we don't allow sample rate to be a value less than 1. We might want to make a note of this in rules.toml and in our docs.
There was a problem hiding this comment.
Ah interesting! We could rethink this and have some other way of indicating that we should drop traffic?
There was a problem hiding this comment.
I could add a drop field. I'll see what that looks like
martin308
force-pushed
the
martin308.rules-sampler
branch
from
4a6fc66 to
a1835a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new sampler type, which implements some basic rules based sampling.