Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make response consistent with Honeycomb API #157

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

martin308
Copy link
Member

The alive check for the honeycomb API uses a string value "yes" to respond to its health check.

https://api.honeycomb.io/x/alive

Update to match

@martin308 martin308 requested a review from a team September 29, 2020 23:55
@martin308
Copy link
Member Author

I think the tests are failing due to the race detector which will be fixed in #156

@martin308 martin308 merged commit 5f7c467 into main Sep 30, 2020
@martin308 martin308 deleted the martin308.consistent-responses branch September 30, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants