Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TotalThroughputSampler a valid sampler. #191

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Make TotalThroughputSampler a valid sampler. #191

merged 1 commit into from
Nov 30, 2020

Conversation

magnusstahre
Copy link
Contributor

No description provided.

@magnusstahre magnusstahre requested a review from a team November 11, 2020 15:25
martin308
martin308 requested changes Nov 12, 2020
View reviewed changes
Copy link
Member

@martin308 martin308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth adding a bunch of extra tests to cover these points we missed!

Could we add:

  • a sample config to rules.toml similar to the others
  • a test in config_test for this sampler config

@magnusstahre magnusstahre force-pushed the validate-totalthroughput branch from c7b55cd to de0ab19 Compare November 30, 2020 17:13
@magnusstahre
Copy link
Contributor Author

@martin308 updated the PR per the requests, please take a look!

@asdvalenzuela asdvalenzuela requested a review from a team November 30, 2020 21:47
martin308
martin308 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@martin308 martin308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@asdvalenzuela asdvalenzuela merged commit 27436b7 into honeycombio:main Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdvalenzuela asdvalenzuela asdvalenzuela approved these changes

@martin308 martin308 martin308 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magnusstahre @martin308 @asdvalenzuela