Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[logger] Properly format duration #199

Merged
merged 1 commit into from
Dec 28, 2020
Merged

[logger] Properly format duration #199

merged 1 commit into from
Dec 28, 2020

Conversation

dstrelau
Copy link
Member

%d prints ns, not ms. %s will format appropriately for all values.

@dstrelau dstrelau requested a review from a team December 21, 2020 21:28
@dstrelau
[logger] Properly format duration
4fbf8a6 
%d prints ns, not ms. %s will format appropriately for all values.
@dstrelau dstrelau force-pushed the dstrelau.fix-timing branch from 9b416d6 to 4fbf8a6 Compare December 21, 2020 22:08
martin308
martin308 approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@martin308 martin308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual code change here looks good. Not sure why the build would be failing on the race detection from this change though 🤔

@asdvalenzuela asdvalenzuela merged commit 1e2de43 into main Dec 28, 2020
@asdvalenzuela asdvalenzuela deleted the dstrelau.fix-timing branch December 28, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdvalenzuela asdvalenzuela asdvalenzuela approved these changes

@martin308 martin308 martin308 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstrelau @martin308 @asdvalenzuela