-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /debug/trace/{traceID} endpoint #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Is there any security considerations here with exposing a hostname on a non-authed endpoint? I'm assuming it's information that's already public.
✨ |
Currently Refinery is expected to only work within a secure network and doesn't setup any authentication credentials so I think we're good for now. If we decide to add authentication later, this endpoint should be secured too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
* main: Add /debug/trace/{traceID} endpoint (#204) # Conflicts: # route/route_test.go
Add a diagnostics HTTP GET endpoint that returns the debug trace information, including the assigned node address using the configured sharding algorithm. The endpoint can be called like this: http://localhost:9000/debug/trace/123abc The response is a JSON object two two properties and looks like the following: {"traceID":"123abc","node":"http://localhost:12345"}
Add a diagnostics HTTP GET endpoint that returns the debug trace information, including the assigned node address using the configured sharding algorithm.
The endpoint can be called like this:
http://localhost:9000/debug/trace/123abc
The response is a JSON object two two properties and looks like the following:
{"traceID":"123abc","node":"http://localhost:12345"}