detect int64 sample rate #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdvalenzuela
approved these changes
Feb 17, 2021
route/route.go
Outdated
| err = fmt.Errorf("Unrecognised sampleRate datatype - %T", attributes["sampleRate"]) | ||
| switch v := attrs[sampleRateKey].(type) { | ||
| case string: | ||
| sampleRate, err = strconv.Atoi(v) |
There was a problem hiding this comment.
Do we need to check for this also or does it not matter as much here? strconv.ParseInt(v, 10, 32)
There was a problem hiding this comment.
Do we need to check for this also or does it not matter as much here?
strconv.ParseInt(v, 10, 32)
Yeah, good point - let's keep it consistent with shepherd. I'll update.
paulosman
force-pushed
the
paul.sample_rate_int64
branch
from
969f4e9 to
b8993fb
Compare
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
Detect int64 / int32 sample rates. Some OTLP exporters will send them as these types - so handle appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect int64 / int32 sample rates. Some OTLP exporters will send them as these types - so handle appropriately.