Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error response from libhoney does not always mean a non-20x response #210

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

vreynolds
Copy link
Contributor

  • it could be a 200 API response that got an error on parsing the body

* it could be a 200 API response that got an error on parsing the body
@vreynolds vreynolds marked this pull request as ready for review February 22, 2021 18:42
@vreynolds vreynolds requested a review from a team February 22, 2021 18:42
@vreynolds vreynolds added the version: bump patch A PR with release-worthy changes and is backwards-compatible. label Feb 22, 2021
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vreynolds vreynolds merged commit 4b9feb1 into main Feb 24, 2021
@vreynolds vreynolds deleted the vera.update-error-message branch February 24, 2021 16:59
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
…oneycombio#210)

* it could be a 200 API response that got an error on parsing the body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants