Add tests for int64 sample rate values #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
Resolves honeycombio#211. Adds testing for parsing int64 sample rate values. Test cases include parsing a value that can be parsed into an int32 and a value greater than int32 max where the int32 max value is used instead. Additionally, replace the custom max int32 value with the math package const math.MaxInt32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #211.
Adds testing for parsing int64 sample rate values. Test cases include parsing a value that can be parsed into an int32 and a value greater than int32 max where the int32 max value is used instead.
Additionally, replace the custom max int32 value with the math package const
math.MaxInt32.