Add environment variables for MetricsAPIKey and LoggerAPIKey #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vreynolds
approved these changes
Mar 12, 2021
vreynolds
added
the
version: bump patch
MikeGoldsmith
pushed a commit
that referenced
this pull request
Mar 22, 2021
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an environment variable binding for both the
HoneycombMetrics.MetricsAPIKeyandHoneycombLogger.LoggerAPIKeyproperties.To keep configs simple, a single environment variable called
REFINERY_HONEYCOMB_API_KEY, is used for both of these properties. Though possible, the use case to send metrics and logs to different teams doesn't make sense, so using the same environment variable for both is ok.By making this an environment variable, the API Key can be securely passed into refinery without being recorded in a plain text script or manifest file.