Log sampler config and validation errors #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vreynolds
reviewed
Mar 22, 2021
config/file_config.go
Outdated
| @@ -311,11 +314,13 @@ func (f *fileConfig) validateSamplerConfigs() error { | |||
| } | |||
| err := f.rules.Unmarshal(i) | |||
| if err != nil { | |||
| logrus.WithError(err).Warn("Failed to unmarshal sampler rule") | |||
There was a problem hiding this comment.
Looks like these validation errors get logged upstream. Would it make sense to add context to the returned error instead of adding a log statement, so that logging is consolidated to the topmost place?
There was a problem hiding this comment.
Yeah, good idea. Maybe something like this to wrap the error?
return fmt.Errorf("Failed to unmarshal sampler rule: %w", err)I used this as reference on how to extend/wrap an err.
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
When loading sampler rules from file based config, it can be difficult to see what rules have been set or any validation errors. This PR logs the sampler config in Debug level and also any unmarshalling / validation errors in Warn level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading sampler rules from file based config, it can be difficult to see what rules have been set or any validation errors.
This PR logs the sampler config in
Debuglevel and also any unmarshalling / validation errors inWarnlevel.