sample: change dynsampler metric names to match rulessampler convention #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vreynolds
added
the
version: bump minor
vreynolds
approved these changes
Apr 12, 2021
|
Thank you! Since |
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the rules implementation and configuring our local Refinery, I noticed a couple of metrics that appeared to be misnamed. All of the other metrics are prefixed with
rulessampler, but these two (for dropping events) are prefixed withdynsampler. This seemed like an oversight, though I'm by no means an expert. This PR changes the "dropped" metrics to conform to the convention of the other metric names.Note that this is a breaking change: any existing dashboards, SLOs, etc built around the rules sampler and using the old metric name may no longer work as intended after this rename. A backwards compatible approach would be to emit both metrics, and then deprecate the
dynsamplerversion later one. I didn't do that here, but am happy to do so if people feel strongly about it.I ran the sampler unit test suite locally & confirmed that it passed with this change.