Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant peer/api suffix from response error metric #247

Merged
merged 1 commit into from
May 19, 2021

Conversation

vreynolds
Copy link
Contributor

* transmission metrics are already prefixed with peer/upstream
* fixes #244
@vreynolds vreynolds added the version: bump minor A PR that adds behavior, but is backwards-compatible. label Apr 12, 2021
@vreynolds vreynolds requested a review from a team April 12, 2021 17:40
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, you're redundant, spiderman

@vreynolds vreynolds merged commit f44521f into main May 19, 2021
@vreynolds vreynolds deleted the vera.update-response-error-metric branch May 19, 2021 16:25
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
…bio#247)

* transmission metrics are already prefixed with peer/upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API errors are incorrectly reported as peer errors
2 participants