Add 'meta.refinery.local_hostname' to all spans

[jharley]

The intention is to help determine issues with a single Refinery instance.

[vreynolds]

Hurm. I tried it out locally, and I'm not seeing the extra metadata on the events. I think the AddField needs to happen before we grab the builder?

[jharley]

Urgh, thank you and my apologies! :\

Adding the field before the builder is created (or on the builder directly) does give the desired result, but it breaks the testsuite as the field is being added all the event data.

If you feel this is useful -- I think it's a helpful addition -- perhaps it should be a config option anyway? Then it can be disabled for the testsuite to avoid having to add the field to all the expected test results. Perhaps something like Config.GetEnableEventHostMetadata?

[vreynolds]

No worries! It wasn't intuitive to me, either.

I like the idea of adding a config option, because there's already something akin to it: AddSampleRateKeyToTrace in the rules config, except this new one (maybe something like AddHostMetadataToTrace = true/false) would be in the general config. That way, a single test that flips that to true can test the hostname, and all other tests should work the same.

Does that make sense?

[jharley]

Makes good sense to me! I'll pick that up and run with it. 🚀

[vreynolds]

Question about the default value, and small update about live reload, otherwise LGTM!

[vreynolds]

@jharley could you update the docs as well? https://docs.honeycomb.io/manage-data-volume/refinery/configuration/#general-configuration

[jharley]

@jharley could you update the docs as well? https://docs.honeycomb.io/manage-data-volume/refinery/configuration/#general-configuration

No problem!