-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OTLP over HTTP/protobuf #279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most recent commits was to add support for gzip/zstd encoding as part of the parsing process. |
vreynolds
requested changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Route requires an extra /1/
path
MikeGoldsmith
added
status: review needed
Changes need review.
type: enhancement
New feature or request
version: bump minor
A PR that adds behavior, but is backwards-compatible.
labels
Jul 13, 2021
vreynolds
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LokeshOpsramp
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
Adds support for ingesting OTLP requests over HTTP with protobuf data. Changs in this PR: - Move the existing gRPC export handler and helpers to to otlp_trace.go and tests into otlp_trace_test.go - Add HTTP handler postOTLP that retrieves honeycomb headers, decodes the request body into a OTLP - ExportTraceRequest and hands to internal function to process request - Update OTLP grpc Export handler to retrieve honeycomb headers from metadata and hand request to new internal function to process - Adds tests to verify rejection behaviour for non-protobuf based requests to postOTLP and test to pass request to postOTLP handler endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: review needed
Changes need review.
type: enhancement
New feature or request
version: bump minor
A PR that adds behavior, but is backwards-compatible.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ingesting OTLP requests over HTTP with protobuf data. Changs in this PR:
postOTLP
that retrieves honeycomb headers, decodes the request body into a OTLP ExportTraceRequest and hands to internal function to process request