Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OTLP over HTTP/protobuf #279

Merged
merged 6 commits into from
Jul 14, 2021
Merged

Add support for OTLP over HTTP/protobuf #279

merged 6 commits into from
Jul 14, 2021

Conversation

MikeGoldsmith
Copy link
Contributor

Adds support for ingesting OTLP requests over HTTP with protobuf data. Changs in this PR:

  • Move the existing gRPC export handler and helpers to to otlp_trace.go and tests into otlp_trace_test.go
  • Add HTTP handler postOTLP that retrieves honeycomb headers, decodes the request body into a OTLP ExportTraceRequest and hands to internal function to process request
  • Update OTLP grpc Export handler to retrieve honeycomb headers from metadata and hand request to new internal function to process
  • Adds tests to verify rejection behaviour for non-protobuf based requests to postOTLP and test to pass request to postOTLP handler endpoint

@MikeGoldsmith MikeGoldsmith requested a review from a team July 1, 2021 20:35
@MikeGoldsmith
Copy link
Contributor Author

Most recent commits was to add support for gzip/zstd encoding as part of the parsing process.

Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Route requires an extra /1/ path

route/otlp_trace_test.go Show resolved Hide resolved
route/route.go Outdated Show resolved Hide resolved
@MikeGoldsmith MikeGoldsmith added status: review needed Changes need review. type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Jul 13, 2021
…-http

* 'main' of github.com:honeycombio/refinery:
  update changelog for 1.3.0 (#282)
  Updates Github Action Workflows (#280)
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

she-ready

@MikeGoldsmith MikeGoldsmith merged commit 15469e8 into main Jul 14, 2021
@MikeGoldsmith MikeGoldsmith deleted the mike/otlp-http branch July 14, 2021 09:40
LokeshOpsramp pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
Adds support for ingesting OTLP requests over HTTP with protobuf data. Changs in this PR:

- Move the existing gRPC export handler and helpers to to otlp_trace.go and tests into otlp_trace_test.go
- Add HTTP handler postOTLP that retrieves honeycomb headers, decodes the request body into a OTLP
- ExportTraceRequest and hands to internal function to process request
- Update OTLP grpc Export handler to retrieve honeycomb headers from metadata and hand request to new internal function to process
- Adds tests to verify rejection behaviour for non-protobuf based requests to postOTLP and test to pass request to postOTLP handler endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: review needed Changes need review. type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants