Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span.kind when ingesting OTLP #299

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Add span.kind when ingesting OTLP #299

merged 1 commit into from
Aug 5, 2021

Conversation

vreynolds
Copy link
Contributor

Customers using OTEL are confused by the absence of span.kind attribute, because we map it to type on ingest. Adding span.kind in, with the plan to let customers know about type being deprecated and removing it in the future.

Updates https://github.com/honeycombio/telemetry-team/issues/14

@vreynolds vreynolds requested a review from a team August 4, 2021 22:44
@vreynolds vreynolds added the version: bump minor A PR that adds behavior, but is backwards-compatible. label Aug 5, 2021
@vreynolds vreynolds merged commit c13edd0 into main Aug 5, 2021
@vreynolds vreynolds deleted the vera.add-span-kind branch August 5, 2021 21:32
@MikeGoldsmith MikeGoldsmith added type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible. and removed version: bump minor A PR that adds behavior, but is backwards-compatible. labels Aug 9, 2021
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants