Add dynamic sampler support to rules based samplers #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
requested changes
Sep 20, 2021
There was a problem hiding this comment.
This looks really nice and is a great start.
It's a shame we can't use sample.Sampler as the type in RulesBasedSamplerRule because it introduces a circular dependency. Maybe that's something we can look at resolving.
I'd like to see the sampler creation moved to Start and a couple of other suggestions.
|
I added I also added support for the TotalThroughput sampler, based on a comment thread in Slack. |
MikeGoldsmith
approved these changes
Sep 29, 2021
robbkidd
added
the
version: bump minor
MikeGoldsmith
added a commit
that referenced
this pull request
Oct 1, 2021
…i-arch-docker * 'main' of github.com:honeycombio/refinery: Add dynamic sampler support to rules based samplers (#317)
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
The RulesBased sample is exclusive to the other samplers. This PR allows you to use Dynamic and EMADynamic samplers to determine the sample rate of a RulesBased sampler rule. Co-authored-by: Mike Goldsmth <goldsmith.mike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The RulesBased sample is exclusive to the other samplers. This PR allows you to use Dynamic and EMADynamic samplers to determine the sample rate of a RulesBased sampler rule.
Short description of the changes
This adds a new
Downstreamoption to a rule configuration. This option can be used to contain either aDynamicSamplerorEMADynamicSampleroption that is a complete configuration of their respective samplers. When defined the downstream sampler will be used to determine the sample rate when all rule conditions are matched.A popular use case is to use RulesBased sampling to keep all error and long duration traces while using a dynamic sampler for all other data, based on key fields.
Closes #283
notes:
Downstreamis the right one here. Naming things is hard.