Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build docker images during publish #336

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Build docker images during publish #336

merged 5 commits into from
Oct 13, 2021

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Oct 12, 2021 •
edited
Loading

Which problem is this PR solving?

When building and publishing a docker image in multiple jobs, only the architecture of the CI runtime is persisted. We want to build and publish all architectures, so we've reverted to building the docker image as part publish step.

Short description of the changes

  • update build-docker.sh to use the KO_DOCKER_REPO env var, defaulting to ko.local for local publishing
  • update circle ci config to build the docker image both in build_docker and publish_docker jobs, with publish setting the KO_DOCKER_REPO env var so ko publishes to Docker Hub.
  • ensure all publish jobs require all build jobs to pass

@MikeGoldsmith MikeGoldsmith added version: bump patch A PR with release-worthy changes and is backwards-compatible. type: maintenance The necessary chores to keep the dust off. labels Oct 12, 2021
@MikeGoldsmith MikeGoldsmith requested a review from a team October 12, 2021 12:14
@MikeGoldsmith MikeGoldsmith changed the title build docker images during publish Build docker images during publish Oct 12, 2021
@MikeGoldsmith MikeGoldsmith self-assigned this Oct 12, 2021
JamieDanielson
JamieDanielson approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JamieDanielson
Copy link
Contributor

The build-docker.sh script worked when running manually with a "dev" tag - results can be seen on docker hub with "dev" tag (https://hub.docker.com/r/honeycombio/refinery/tags).

A future nice-to-have: publish a dev image to docker on every commit. Maybe on the next big change, nothing to hold this up right now.

@MikeGoldsmith MikeGoldsmith merged commit 0f24ad0 into main Oct 13, 2021
@MikeGoldsmith MikeGoldsmith deleted the mike/multi-arch-docker-fix branch October 13, 2021 10:04
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@MikeGoldsmith @JamieDanielson
Build docker images during publish (honeycombio#336)
c52834e 
When building and publishing a docker image in multiple jobs, only the architecture of the CI runtime is persisted. We want to build and publish all architectures, so we've reverted to building the docker image as part publish step.

Co-authored-by: JamieDanielson <jamieedanielson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieDanielson JamieDanielson JamieDanielson approved these changes

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: maintenance The necessary chores to keep the dust off. version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multi-arch docker publish broke
2 participants
@MikeGoldsmith @JamieDanielson