Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add missing docker login when publishing #338

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Re-add missing docker login when publishing #338

merged 3 commits into from
Oct 13, 2021

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

We need to provide login credentials for publishing to DockerHub, these were accidentally removed while refactoring.

Short description of the changes

  • re-add docker login command when publishing

@MikeGoldsmith MikeGoldsmith added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Oct 13, 2021
@MikeGoldsmith MikeGoldsmith requested a review from a team October 13, 2021 13:34
JamieDanielson
JamieDanielson requested changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed the old env vars, these are the new ones to use in the Honeycomb Secrets context

.circleci/config.yml Outdated Show resolved Hide resolved
@JamieDanielson JamieDanielson self-requested a review October 13, 2021 14:40
@JamieDanielson JamieDanielson merged commit d7ba929 into main Oct 13, 2021
@JamieDanielson JamieDanielson deleted the mike/add-missing-docker-login branch October 13, 2021 14:45
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@MikeGoldsmith @JamieDanielson
Re-add missing docker login when publishing (honeycombio#338)
42ebc7e 
* re-add missing docker login when publishing

* Update env vars for docker login

* Fix docker login command

Co-authored-by: JamieDanielson <jamieedanielson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieDanielson JamieDanielson JamieDanielson approved these changes

Assignees
No one assigned
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeGoldsmith @JamieDanielson