Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an --interface-names flag #342

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Add an --interface-names flag #342

merged 2 commits into from
Nov 2, 2021

Conversation

ismith
Copy link
Contributor

@ismith ismith commented Nov 1, 2021

Our config lets you specify which network name to use for peers; this
flag makes it easier to discover what interfaces the binary has
available.

Example, on a locally-built image:

± docker run  -t ko.local/refinery:e2915c3075fd17b54c155f53b04acf0cff1a027a5610cc7bf25052d0725bd7ed --interface-names
lo
eth0

@ismith
Add an --interface-names flag
429373d 
Our config lets you specify which network name to use for peers; this
flag makes it easier to discover what interfaces the binary has
available.

Example, on a locally-built image:
```
± docker run  -t ko.local/refinery:e2915c3075fd17b54c155f53b04acf0cff1a027a5610cc7bf25052d0725bd7ed --interface-names
lo
eth0
```
@ismith ismith requested a review from a team November 1, 2021 23:19
@ismith ismith added the type: enhancement New feature or request label Nov 1, 2021
MikeGoldsmith
MikeGoldsmith approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

Thanks for updating the flaky test timings too.

@ismith ismith merged commit 48470af into main Nov 2, 2021
@ismith ismith deleted the show-interfaces branch November 2, 2021 13:59
MikeGoldsmith added a commit that referenced this pull request Nov 9, 2021
@MikeGoldsmith
Merge branch 'main' of github.com:honeycombio/refinery into mike/husky
aaf4190 
* 'main' of github.com:honeycombio/refinery:
  prepare v1.6.0 release (#348)
  bump libhoney-go to v1.15.6 (#347)
  Use alpine as base image (#343)
  empower apply-labels action to apply labels (#344)
  Add an --interface-names flag (#342)

# Conflicts:
#	go.mod
#	go.sum
@MikeGoldsmith MikeGoldsmith mentioned this pull request Nov 12, 2021
Closed
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@ismith
Add an --interface-names flag (honeycombio#342)
1105dd3 
* Add an --interface-names flag

Our config lets you specify which network name to use for peers; this
flag makes it easier to discover what interfaces the binary has
available.

Example, on a locally-built image:
```
± docker run  -t ko.local/refinery:e2915c3075fd17b54c155f53b04acf0cff1a027a5610cc7bf25052d0725bd7ed --interface-names
lo
eth0
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismith @MikeGoldsmith