Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use alpine as base image (#343)" #352

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

JamieDanielson
Copy link
Contributor

This reverts commit 7614a6e.

Which problem is this PR solving?

Short description of the changes

  • As mentioned in the linked issue, running with no command line arguments produced the command line parsing error. By removing this base image, there are no issues running sans command line args.

@JamieDanielson JamieDanielson requested a review from a team November 10, 2021 22:11
@JamieDanielson JamieDanielson self-assigned this Nov 10, 2021
@JamieDanielson JamieDanielson added type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible. labels Nov 10, 2021
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 on the revert to restore previous behavior (able to run without arguments).

And we ought to open an enhancement issue to consider the original desire for debugging tools available within a Refinery image while also being able to run without arguments.

@JamieDanielson JamieDanielson merged commit 2f34bae into main Nov 10, 2021
@JamieDanielson JamieDanielson deleted the jamie.revert-alpine branch November 10, 2021 22:36
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refinery 1.6.0 Docker image fails to start without arguments
2 participants