Improves histogram buckets over the default set #355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at a usable set of buckets for a wide range of metrics
Which problem is this PR solving?
Fixes #115
As noted in the issue, the default buckets in the go client are as follows:
… and from the docs …
Additionally from the docs …
In the end, the
cache_entries
metric therefore always ends up in the implicit +inf bucket and makes the metric nearly useless. You just know yourcache_entries
are more than 10.For example "your stuff is more than 10!":