Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make MaxBatchSize configurable #365

Merged
merged 7 commits into from
Dec 7, 2021
Merged

feat: Make MaxBatchSize configurable #365

merged 7 commits into from
Dec 7, 2021

Conversation

JamieDanielson
Copy link
Contributor

Which problem is this PR solving?

  • MaxBatchSize is currently hardcoded to 500 with no ability to override

Short description of the changes

  • Add config option for MaxBatchSize, with default of 500

@JamieDanielson JamieDanielson requested a review from a team December 6, 2021 23:56
@JamieDanielson JamieDanielson added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Dec 6, 2021
@JamieDanielson JamieDanielson self-assigned this Dec 6, 2021
vreynolds
vreynolds reviewed Dec 6, 2021
View reviewed changes
config/file_config.go Outdated Show resolved Hide resolved
MikeGoldsmith
MikeGoldsmith reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one comment about switching to uint.

config/mock.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
MikeGoldsmith
MikeGoldsmith approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor formatting fix 👍🏻

config/file_config.go Outdated Show resolved Hide resolved
@JamieDanielson @MikeGoldsmith
Update config/file_config.go
8da209b 
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
@MikeGoldsmith MikeGoldsmith mentioned this pull request Dec 7, 2021
Closed
@JamieDanielson JamieDanielson merged commit 5d57c74 into main Dec 7, 2021
@JamieDanielson JamieDanielson deleted the jamie.max-batch-config branch December 7, 2021 17:10
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@JamieDanielson @MikeGoldsmith
feat: Make MaxBatchSize configurable (honeycombio#365)
5596ec9 
* Make MaxBatchSize configurable
* Make MaxBatchSize uint in Config

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@vreynolds vreynolds Awaiting requested review from vreynolds

Assignees

@JamieDanielson JamieDanielson

Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieDanielson @MikeGoldsmith @vreynolds