Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor environment variable to set gRPC listener address #386

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

seh
Copy link
Contributor

@seh seh commented Jan 27, 2022

Introduce the "REFINERY_GRPC_LISTEN_ADDRESS" environment variable to allow setting Refinery's GRPCListenAddr configuration field, overriding any such configuration read from a file.

Fixes #383.

@seh seh requested a review from a team January 27, 2022 20:53
@seh seh changed the title Honor environment variable to set GRP listener address Honor environment variable to set gRPC listener address Jan 27, 2022
@seh seh force-pushed the honor-grpc-address-env-var branch from 69dae29 to ca8429d Compare January 27, 2022 20:55
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @seh - it looks great. Just one small ask on reverting the build tags.

It helps address some of #275 too.

config/config_test.go Outdated Show resolved Hide resolved
Introduce the "REFINERY_GRPC_LISTEN_ADDRESS" environment variable to
allow setting Refinery's "GRPCListenAddr" configuration field,
overriding any such configuration read from a file.
@seh seh force-pushed the honor-grpc-address-env-var branch from ca8429d to f65b90c Compare January 31, 2022 15:23
@MikeGoldsmith MikeGoldsmith merged commit 4344c02 into honeycombio:main Feb 1, 2022
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce environment variable for Refinery's gRPC listener's bind address
2 participants