Properly set meta.refinery.local_hostname field #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this will get called with each outgoing span, instead of just once at startup, does it make sense to cache the hostname and reuse it instead of calling |
MikeGoldsmith
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Thanks for working on this @jharley.
I made a small adjustment to get the hostname during the collector Start func to be reused across all traces.
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
Co-authored-by: Mike Goldsmth <goldsmith.mike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the hostname is set before transmitting upstream to the current hostname.
Which problem is this PR solving?
Short description of the changes