Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add ARM64 RPM artifact #395

Merged
merged 1 commit into from
Feb 8, 2022
Merged

build: add ARM64 RPM artifact #395

merged 1 commit into from
Feb 8, 2022

Conversation

jharley
Copy link
Contributor

@jharley jharley commented Feb 3, 2022

Which problem is this PR solving?

Missing ARM64 RPM artifact (Amazon Linux, RedHat, Rocky, etc)

Short description of the changes

Adds an ARM64 RPM to the released artifacts.

@jharley jharley added the merge at will Reviewer can merge the PR once reviewed. label Feb 3, 2022
@jharley jharley requested a review from a team February 3, 2022 21:04
MikeGoldsmith
MikeGoldsmith approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jharley 🎉

@MikeGoldsmith
Copy link
Contributor

MikeGoldsmith commented Feb 7, 2022 •
edited
Loading

Looking at the CircleCI build, the output file is named refinery-ea71155-1.aarch64.rpm. Would it be more appropriate to rename to refinery-ea71155-1.arm64.rpm?

@jharley
Copy link
Contributor Author

jharley commented Feb 7, 2022

Looking at the CircleCI build, the output file is named refinery-ea71155-1.aarch64.rpm. Would it be more appropriate to rename to refinery-ea71155-1.arm64.rpm?

Looking at the Rocky Linux packages I think aarch64 is correct

@jharley jharley merged commit 9b99182 into main Feb 8, 2022
@jharley jharley deleted the jharley.build-arm64-rpm branch February 8, 2022 16:34
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@jharley
build: add ARM64 (aarch64) RPM artifact (honeycombio#395)
43b851d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees
No one assigned
Labels
merge at will Reviewer can merge the PR once reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jharley @MikeGoldsmith