Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error log event metadata #422

Merged
merged 2 commits into from
Mar 24, 2022
Merged

fix: error log event metadata #422

merged 2 commits into from
Mar 24, 2022

Conversation

vreynolds
Copy link
Contributor

Which problem is this PR solving?

  • Refinery logs errors that it receives from libhoney (e.g. events are too large), but does not log any useful identifying information, making it very hard to find the source of the error
  • internal slack thread

Short description of the changes

  • aligned metadata attached to events with what we attach to error logs
  • event_type and target used to be properties on libhoney events, but are now gone, so 🤷

how errors look before this change:

ERRO[0149] error when sending event                      api_host= dataset= error="got unexpected HTTP status 401: Unauthorized" event_type= status_code=401 target=

how error look after this change

ERRO[0219] error when sending event                      api_host="https://api-dogfood.honeycomb.io" dataset=year-java environment="huzzah env" error="got unexpected HTTP status 401: Unauthorized" status_code=401

@vreynolds vreynolds requested a review from a team March 23, 2022 19:00
@vreynolds vreynolds added type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible. labels Mar 23, 2022
@vreynolds vreynolds merged commit f3b0256 into main Mar 24, 2022
@vreynolds vreynolds deleted the vera.improve-error-logs branch March 24, 2022 18:43
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
aligned metadata attached to events with what we attach to error logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants