Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hand-rolled binary.BigEndian.Uint32 with the real deal #459

Merged
merged 1 commit into from
May 25, 2022
Merged

Replace hand-rolled binary.BigEndian.Uint32 with the real deal #459

merged 1 commit into from
May 25, 2022

Conversation

toshok
Copy link

@toshok toshok commented May 25, 2022

bytesToUint32be is exactly binary.BigEndian.Uint32 (go source), and is duplicated in the two spots where we use it. might as well save a few lines of code.

@toshok toshok requested a review from a team May 25, 2022 03:47
MikeGoldsmith
MikeGoldsmith approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @toshok 👍🏻

@MikeGoldsmith MikeGoldsmith added version: bump patch A PR with release-worthy changes and is backwards-compatible. type: maintenance The necessary chores to keep the dust off. labels May 25, 2022
@MikeGoldsmith MikeGoldsmith changed the title replace hand-rolled binary.BigEndian.Uint32 with the real deal Replace hand-rolled binary.BigEndian.Uint32 with the real deal May 25, 2022
@MikeGoldsmith MikeGoldsmith merged commit 91a063c into honeycombio:main May 25, 2022
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
Replace hand-rolled binary.BigEndian.Uint32 with the real deal (honey…
91c2907 
…combio#459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@toshok toshok

Labels
type: maintenance The necessary chores to keep the dust off. version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toshok @MikeGoldsmith