Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Husky to latest #505

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Update Husky to latest #505

merged 1 commit into from
Sep 7, 2022

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update husky
  • Replace otel package imports with husky versions, eggo.opentelemetry.io/otel => github.com/honeycombio/husky/otel
  • Replace any usage of InstrumentationLibrary* with Scope equivalents, eg InstrumentationLibrary => InstrumentationScope
  • Fix test that verified that OTLP/HTTP didn't work to one that shows it does (at a basic level)

@kentquirk kentquirk requested review from a team and emilyashley September 7, 2022 14:01
@MikeGoldsmith MikeGoldsmith added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Sep 7, 2022
@kentquirk kentquirk merged commit 7c00ab6 into main Sep 7, 2022
@kentquirk kentquirk deleted the kent.update_husky branch September 7, 2022 15:22
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@kentquirk
Update Husky to latest (honeycombio#505)
d731a34 
## Which problem is this PR solving?

- Updates Husky to our 0.15.0
- Closes honeycombio#493 

## Short description of the changes

- Update husky
- Replace otel package imports with husky versions,  eg[go.opentelemetry.io/otel](http://go.opentelemetry.io/otel) => [github.com/honeycombio/husky/otel](http://github.com/honeycombio/husky/otel)
- Replace any usage of InstrumentationLibrary* with Scope equivalents, eg InstrumentationLibrary => InstrumentationScope
- Fix test that verified that OTLP/HTTP didn't work to one that shows it does (at a basic level)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@emilyashley emilyashley Awaiting requested review from emilyashley

Assignees

@kentquirk kentquirk

Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @MikeGoldsmith