Add support for metrics api key env var #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
approved these changes
Oct 4, 2022
| @@ -119,7 +119,7 @@ func NewConfig(config, rules string, errorCallback func(error)) (Config, error) | |||
| c.BindEnv("PeerManagement.RedisUsername", "REFINERY_REDIS_USERNAME") | |||
| c.BindEnv("PeerManagement.RedisPassword", "REFINERY_REDIS_PASSWORD") | |||
| c.BindEnv("HoneycombLogger.LoggerAPIKey", "REFINERY_HONEYCOMB_API_KEY") | |||
| c.BindEnv("HoneycombMetrics.MetricsAPIKey", "REFINERY_HONEYCOMB_API_KEY") | |||
| c.BindEnv("HoneycombMetrics.MetricsAPIKey", "REFINERY_HONEYCOMB_METRICS_API_KEY", "REFINERY_HONEYCOMB_API_KEY") | |||
There was a problem hiding this comment.
dang, today I learned that BindEnv takes multiple arguments. Now I need to go look at other uses.
TylerHelmuth
added
the
version: bump patch
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
## Which problem is this PR solving? Allows setting `HoneycombMetrics.MetricsAPIKey` with a specific environment variable. - Fixes honeycombio#520 ## Short description of the changes - Utilizes viper's BindEnv() function to handle env var precedence for `HoneycombMetrics.MetricsAPIKey`. - If `REFINERY_HONEYCOMB_METRICS_API_KEY` is set then it will be used. Otherwise `REFINERY_HONEYCOMB_API_KEY` will be used. As a result existing customer configs will not be affected. - Added new unit tests for this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Allows setting
HoneycombMetrics.MetricsAPIKeywith a specific environment variable.Short description of the changes
HoneycombMetrics.MetricsAPIKey.REFINERY_HONEYCOMB_METRICS_API_KEYis set then it will be used. OtherwiseREFINERY_HONEYCOMB_API_KEYwill be used. As a result existing customer configs will not be affected.