On shutdown, remove ourself from the peers list #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
commented
Nov 23, 2022
| @@ -1,5 +1,3 @@ | |||
| //go:build all || race | |||
There was a problem hiding this comment.
We don't need these build flags any more so I removed them.
kentquirk
added
type: enhancement
TylerHelmuth
approved these changes
Nov 23, 2022
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
## Which problem is this PR solving? - In a redis-managed pool of peers, the peer group is updated only after a timeout. This adds explicit unregistration so that in the case of a deliberately terminated instance, redis is notified immediately that the peer has dropped. - Doesn't change the behavior of refreshing the peer list, which is still a pull-based timeout. - Fixes honeycombio#393 ## Short description of the changes - Add an Unregister method to redimem - Add a done channel to the goroutines that keep redis updated - Unregister when the done channel is closed - Propagate the done channel through the app initialization - Close the done channel on shutdown - Update tests - Add a new test to make sure that unregistration happens - Also adds a new test case to rules; I wrote it to verify we didn't have a bug and thought it should probably stay in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes