feat: allow user to convert datatype if valid #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchikwekwe
changed the title
fchikwekwe
changed the title
There was a problem hiding this comment.
@fchikwekwe left a couple questions and a couple nits. Great work!
fchikwekwe
force-pushed
the
faith/rules-convert-datatypes
branch
from
df64c34 to
437b3ed
Compare
kentquirk
reviewed
Jan 27, 2023
fchikwekwe
force-pushed
the
faith/rules-convert-datatypes
branch
from
75d743e to
d116409
Compare
TylerHelmuth
approved these changes
Jan 31, 2023
| if !conditionMatchesValue(condition, value, exists) { | ||
| ruleMatched = false | ||
| break // if any condition fails, we can't possibly succeed, so exit inner loop early | ||
| if condition.Matches != nil { |
There was a problem hiding this comment.
If we make it here we know condition.Matches != nil so I believe we replace this if statement with an else if statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes