Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend and unify metrics system #593

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

In service of being able to monitor the performance of refinery from within refinery itself, this PR extends refinery's Metrics system to add a few things:

  • Use only one metrics object rather than several strewn about the system
  • Move the "prefix" feature of metrics to a wrapper (metricsnamer) that applies the prefix on metric creation rather than during metrics reporting.
  • Add the ability of metrics to have updown metrics
  • Give metrics the ability to store constants that are not reported

The result of these changes is to allow the upcoming stress relief system to accurately calculate stress based on the metrics the system is already (or soon to be) tracking.

This set of changes should be transparent to the operation of refinery -- all existing metrics should work just as they have already.

@kentquirk kentquirk requested a review from a team as a code owner January 31, 2023 17:57
@kentquirk kentquirk added type: enhancement New feature or request version: bump patch A PR with release-worthy changes and is backwards-compatible. status: review needed Changes need review. labels Jan 31, 2023
collect/collect.go Outdated Show resolved Hide resolved
metrics/honeycomb.go Show resolved Hide resolved
@kentquirk kentquirk force-pushed the kent.metrics_for_stress branch from c1e4d74 to cbd967b Compare February 1, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: review needed Changes need review. type: enhancement New feature or request version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants