fix: do not send sample rate in dry run #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchikwekwe
force-pushed
the
faith/no-sameple-rate-in-dryrun
branch
from
79721a9 to
18da695
Compare
kentquirk
approved these changes
Feb 24, 2023
TylerHelmuth
approved these changes
Feb 24, 2023
fchikwekwe
changed the title
fchikwekwe
added
type: bug
|
Thanks for the reviews. Updated PR title. |
|
Nice! Love to see it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415
This issues prevents sending the actual sample rate in dry run mode, instead adding a metric called
meta.dryrun.sample_rateso that a user can know what their sample rate in dry run mode would have been.