Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to set Redis database and prefix in config #614

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented Feb 24, 2023

Which problem is this PR solving?

In a blue/green deployment model, two refinery clusters might want to share the same instance of redis. It's also possible that multiple apps want to share one redis. This permits that by:

  • allowing the redis "database" (an integer from 0-15) to be specified in the configuration
  • allowing the redis "prefix" (a string used in the name of the keys stored in redis) to be set as well. It already existed but was hardcoded to "refinery".

Short description of the changes

  • Add RedisDatabase and RedisPrefix to the PeerManagement section of config.
  • Add tests
  • Add documentation

Fixes #544

@kentquirk kentquirk requested a review from a team as a code owner February 24, 2023 04:01
@kentquirk kentquirk changed the title Add ability to set Redis database in config feat: Add ability to set Redis database in config Feb 24, 2023
@kentquirk kentquirk changed the title feat: Add ability to set Redis database in config WIP: Add ability to set Redis database and prefix in config Feb 24, 2023
@kentquirk kentquirk changed the title WIP: Add ability to set Redis database and prefix in config feat: Add ability to set Redis database and prefix in config Feb 24, 2023
config_complete.toml Outdated Show resolved Hide resolved
@kentquirk kentquirk merged commit 4f9ced7 into main Feb 24, 2023
@kentquirk kentquirk deleted the kent.redis_db branch February 24, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis peer prefix/namespace are not configurable
2 participants